Surface swallowed errors across pipeline and UI - #13
Surface swallowed errors across pipeline and UI#13devin-ai-integration[bot] wants to merge 6 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06bc155384
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| monkeypatch.setattr(update_master, "build_restricted_datasets", _boom) | ||
| monkeypatch.setattr(update_master, "_load_dataframe", lambda *_a, **_k: pd.DataFrame()) | ||
| monkeypatch.setattr(update_master, "_write_master_outputs", lambda *_a, **_k: None, raising=False) |
There was a problem hiding this comment.
This monkeypatch creates _write_master_outputs, but update_master_database() never calls that helper; it writes to SOLD_FILE, REFERRED_FILE, and ACTIVE_FILE directly via _merge_preserving_history()/_atomic_write() before build_restricted_datasets() is reached. In a normal pytest run against the tracked CSV_data baseline, this test can rewrite the real runtime CSVs while only intending to assert the raised RuntimeError; redirect the file constants or write helpers to tmp_path instead.
AGENTS.md reference: AGENTS.md:L101-L102
Useful? React with 👍 / 👎.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Replays PR13 on deployed current main and preserves the UI-safe remote-upload fallback with visible error logging.
3 participants
Summary
Rebuild on current main
maincommita32840e2aeda35Validation
23 passed970 passed, 1 expected xfail408/408observed tags covered,0errors (13existing warnings)A full-suite run with pytest temp files inside the repository exposes the existing curve-version relative-vs-absolute path assertion; unchanged current main reproduces it. Moving pytest temp files outside the repository gives the clean result above and keeps that unrelated baseline issue out of this PR.